kms/vc4_hdmi: Refuse 4096x2160@60 hdmi modes #5038
Conversation
|
Submitted as draft to hear comments. |
|
Updated to also check if core_freq_min is boosted and only then allow these modes. |
|
Looks reasonable to me as we know that 4096x2160 does require a higher core clock than 3840x2160 to allow the HVS time to generate all the pixels, even though they use the same pixel clock. |
|
As long as they are still accessible if the proper lines are added to config.txt this seems like a reasonable thing to do. |
|
In my testing the 4096x2160@50/60 modes were omitted by default and were present when were added. |
|
This should perhaps be documented somewhere, since the Pi 4 is described as supporting 4K. The obvious location for documentation would be https://github.com/raspberrypi/documentation. Would you like me to submit a PR to have this added? An alternative would be to have the software print out a statement that the requested mode requires overclocking. |
|
I think the common definition of 4k is 3840x2160, but yes, feel to submit a PR that clarifies that 4096x2160@60 is not supported without a core frequency overclock to 600MHz. |
Just for completeness here, 4096 x 2160 @ 60Hz (and 50Hz) is listed as supported by Pi 4 currently in the documentation (at https://www.raspberrypi.com/documentation/computers/config_txt.html#hdmi_mode). |
|
Can I just check - if core_freq_min is set to 600, without setting core_freq, then is that not the same as setting both core_freq_min and core_freq to 600? Just trying to nail down the simplest config. |
ghost
mentioned this pull request
|
There's enough diversity of usage both amature and profesional that the
term 4k should probably be retired in favor of quoting the actual
horizontal resolution.
…On Tue, May 17, 2022 at 12:32 PM andrum99 ***@***.***> wrote:
I think the common definition of 4k is 3840x2160, but yes, feel to submit
a PR that clarifies that ***@***.*** is not supported without a core
frequency overclock to 600MHz.
Will do. Should I perhaps use the frame dimension cutoff (i.e. >3840 or
>2160) from this PR, or would you prefer it to just specify this one video
mode?
—
Reply to this email directly, view it on GitHub
<#5038 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANPGZ5LDIU43GKN5TPSV2YTVKPX5JANCNFSM5WESUUMQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
4K is 4.096 x 2.160 and |
plenty of TVs proudly proclaim 4k on the box but are really 3840x even if the terms are well defined the usage doesn't reflect that |
|
@pelwell okay to merge? |
drivers/gpu/drm/vc4/vc4_drv.h
Outdated
| * 4096x2160@60 requires a core overclock to work, so register | ||
| * whether that is sufficient. | ||
| */ | ||
| bool vc5_hdmi_enable_4096by2160 |
There was a problem hiding this comment.
Indeed. gcc only gives a warning for this, which seems surprising.
These are no reliable without overclocking. See: raspberrypi#5034 Signed-off-by: Dom Cobley <popcornmix@gmail.com>
|
Updated. |
kernel: kms/vc4_hdmi: Refuse 4096x2160@60 hdmi modes See: raspberrypi/linux#5038 kernel: vc-sm-cma: Restore correct cache maintainance operations See: raspberrypi/linux#5047
kernel: kms/vc4_hdmi: Refuse 4096x2160@60 hdmi modes See: raspberrypi/linux#5038 kernel: vc-sm-cma: Restore correct cache maintainance operations See: raspberrypi/linux#5047
These are no reliable without overclocking.
See: #5034
Signed-off-by: Dom Cobley popcornmix@gmail.com